Re: SlicerDMRI build on Windows

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: SlicerDMRI build on Windows

Isaiah Norton-2
Hi Csaba,

To follow-up, the main library install issue you mentioned has been corrected, and the Windows tests are green on the factory. Thanks again!

The failure of ROI Seeding in a local build, I can reproduce, and the issue is that the vtkDMRI library is needed by modules in both qt-loadable-library and cli-modules (it is installed in qt-loadable). In a distribution build this works fine, because the launcher includes all paths. But in a local build the launcher does not add the extra paths -- because there are multiple .ini config files. So we end up with a load failure due to unresolved DLL. It's the same as this issue:

I'll see if there's a minimal fix for now (maybe statically link the CLIs that need it)

Best,
Isaiah

On Thu, Mar 23, 2017 at 7:13 PM, Csaba Pinter <[hidden email]> wrote:

Hi Isaiah,

 

FYI I did a fetch and rebase, then a clean build, and still there is one vtkDMRI.dll in the superbuild folder, at the same location I wrote earlier. Not sure why it’s not installed…

 

csaba

 

From: Isaiah Norton [mailto:[hidden email]]
Sent: Thursday, March 23, 2017 18:49


To: Csaba Pinter <[hidden email]>
Cc: Slicer Developers Mailing List ([hidden email]) <[hidden email]>
Subject: Re: SlicerDMRI build on Windows

 

I pushed a commit to put the library in the loadable module directory at build time, even without running install. So hopefully now the AdditionalLauncherSettings will work as expected in a local/non-install build.

 

I'm not sure about those install errors, will debug as soon as I have a windows build. It seems to work during packaging, because the library ends up in the correct place in the nightly (and all of that functionality is ok).

 

Thanks!

Isaiah

 

On Thu, Mar 23, 2017 at 1:49 PM, Csaba Pinter <[hidden email]> wrote:

Hi Isaiah,

 

I did the local fix so that I can do the work I wanted, but wanted to check with you in case the Windows release is broken.

 

Not sure whether the install step was included when I built the superbuild, but when I try to do it (in the inner-build solution, as install is not in the superbuild one), then I get errors, see below.

Important to note that superbuild succeeds, there are no errors, but still, many tests fail on windows (and not on Linux or Mac), see

http://slicer.cdash.org/index.php?project=Slicer4&filtercount=1&showfilters=1&field1=label&compare1=63&value1=SlicerDMRI

Many of the failing tests belong to the two modules that are not loaded on Windows when starting Slicer because of the missing dll (TractographyDisplay and TractographyInteractiveSeeding). It is possible that vtkDMRI.dll is not deployed on the factory either.

 

csaba

 

 

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: The command "setlocal

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: "C:\Program Files\CMake\bin\cmake.exe" -DBUILD_TYPE=Debug -P cmake_install.cmake

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: if %errorlevel% neq 0 goto :cmEnd

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: :cmEnd

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: :cmErrorLevel

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: exit /b %1

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: :cmDone

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: if %errorlevel% neq 0 goto :VCEnd

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: :VCEnd" exited with code 1.

========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

 

 

From: Isaiah Norton [mailto:[hidden email]]
Sent: Thursday, March 23, 2017 13:42
To: Csaba Pinter <[hidden email]>
Cc: Slicer Developers Mailing List ([hidden email]) <[hidden email]>
Subject: Re: SlicerDMRI build on Windows

 

Hi Csaba,

 

Just to check, did you run the install target? It is supposed to install in `Slicer_INSTALL_QTLOADABLEMODULES_LIB_DIR` alongside the other shared libraries. This works correctly in the nightlies, but I haven't tried a local Windows build recently. (manually adding that `inner-build\...` path to the module search paths should work for a quick local fix)

 

I need to set up a Windows build again anyway, so I'll see if the current CMakeList can be improved for a local debug build.

 

Best,

Isaiah

 

On Thu, Mar 23, 2017 at 12:41 PM, Csaba Pinter <[hidden email]> wrote:

Hi Isaiah,

 

I’m trying to use a build SlicerDMRI on Windows, but some DLLs are apparently not loaded, because vtkDMRI.dll is not found. I built the superbuild, the paths (Qt, VTK) look fine, and vtkDMRI.dll is built, and can be found in

c:\d\_Other\SlicerDMRI_D\inner-build\Libs\vtkDMRI\Debug\vtkDMRI.dll

 

Where is it supposed to be deployed? I see references to a folder C:/d/_Other/SlicerDMRI_D/lib/Slicer-4.7/Debug in AdditionalLauncherSettings.ini, but C:/d/_Other/SlicerDMRI_D/lib does not exist.

 

Any ideas?

 

Thanks,

csaba

 

 



_______________________________________________
slicer-devel mailing list
[hidden email]
http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel
To unsubscribe: send email to [hidden email] with unsubscribe as the subject
http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ
Reply | Threaded
Open this post in threaded view
|

Re: SlicerDMRI build on Windows

pinter

Thank you for the quick investigation and resolution of the issues!

 

csaba

 

From: Isaiah Norton [mailto:[hidden email]]
Sent: Wednesday, April 5, 2017 18:46
To: Csaba Pinter <[hidden email]>
Cc: Slicer Developers Mailing List ([hidden email]) <[hidden email]>
Subject: Re: SlicerDMRI build on Windows

 

Hi Csaba,

 

To follow-up, the main library install issue you mentioned has been corrected, and the Windows tests are green on the factory. Thanks again!

 

The failure of ROI Seeding in a local build, I can reproduce, and the issue is that the vtkDMRI library is needed by modules in both qt-loadable-library and cli-modules (it is installed in qt-loadable). In a distribution build this works fine, because the launcher includes all paths. But in a local build the launcher does not add the extra paths -- because there are multiple .ini config files. So we end up with a load failure due to unresolved DLL. It's the same as this issue:

 

I'll see if there's a minimal fix for now (maybe statically link the CLIs that need it)

 

Best,

Isaiah

 

On Thu, Mar 23, 2017 at 7:13 PM, Csaba Pinter <[hidden email]> wrote:

Hi Isaiah,

 

FYI I did a fetch and rebase, then a clean build, and still there is one vtkDMRI.dll in the superbuild folder, at the same location I wrote earlier. Not sure why it’s not installed…

 

csaba

 

From: Isaiah Norton [mailto:[hidden email]]
Sent: Thursday, March 23, 2017 18:49


To: Csaba Pinter <[hidden email]>
Cc: Slicer Developers Mailing List ([hidden email]) <[hidden email]>
Subject: Re: SlicerDMRI build on Windows

 

I pushed a commit to put the library in the loadable module directory at build time, even without running install. So hopefully now the AdditionalLauncherSettings will work as expected in a local/non-install build.

 

I'm not sure about those install errors, will debug as soon as I have a windows build. It seems to work during packaging, because the library ends up in the correct place in the nightly (and all of that functionality is ok).

 

Thanks!

Isaiah

 

On Thu, Mar 23, 2017 at 1:49 PM, Csaba Pinter <[hidden email]> wrote:

Hi Isaiah,

 

I did the local fix so that I can do the work I wanted, but wanted to check with you in case the Windows release is broken.

 

Not sure whether the install step was included when I built the superbuild, but when I try to do it (in the inner-build solution, as install is not in the superbuild one), then I get errors, see below.

Important to note that superbuild succeeds, there are no errors, but still, many tests fail on windows (and not on Linux or Mac), see

http://slicer.cdash.org/index.php?project=Slicer4&filtercount=1&showfilters=1&field1=label&compare1=63&value1=SlicerDMRI

Many of the failing tests belong to the two modules that are not loaded on Windows when starting Slicer because of the missing dll (TractographyDisplay and TractographyInteractiveSeeding). It is possible that vtkDMRI.dll is not deployed on the factory either.

 

csaba

 

 

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: The command "setlocal

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: "C:\Program Files\CMake\bin\cmake.exe" -DBUILD_TYPE=Debug -P cmake_install.cmake

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: if %errorlevel% neq 0 goto :cmEnd

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: :cmEnd

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: endlocal & call :cmErrorLevel %errorlevel% & goto :cmDone

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: :cmErrorLevel

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: exit /b %1

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: :cmDone

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: if %errorlevel% neq 0 goto :VCEnd

1>C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.CppCommon.targets(132,5): error MSB3073: :VCEnd" exited with code 1.

========== Build: 0 succeeded, 1 failed, 0 up-to-date, 0 skipped ==========

 

 

From: Isaiah Norton [mailto:[hidden email]]
Sent: Thursday, March 23, 2017 13:42
To: Csaba Pinter <[hidden email]>
Cc: Slicer Developers Mailing List ([hidden email]) <[hidden email]>
Subject: Re: SlicerDMRI build on Windows

 

Hi Csaba,

 

Just to check, did you run the install target? It is supposed to install in `Slicer_INSTALL_QTLOADABLEMODULES_LIB_DIR` alongside the other shared libraries. This works correctly in the nightlies, but I haven't tried a local Windows build recently. (manually adding that `inner-build\...` path to the module search paths should work for a quick local fix)

 

I need to set up a Windows build again anyway, so I'll see if the current CMakeList can be improved for a local debug build.

 

Best,

Isaiah

 

On Thu, Mar 23, 2017 at 12:41 PM, Csaba Pinter <[hidden email]> wrote:

Hi Isaiah,

 

I’m trying to use a build SlicerDMRI on Windows, but some DLLs are apparently not loaded, because vtkDMRI.dll is not found. I built the superbuild, the paths (Qt, VTK) look fine, and vtkDMRI.dll is built, and can be found in

c:\d\_Other\SlicerDMRI_D\inner-build\Libs\vtkDMRI\Debug\vtkDMRI.dll

 

Where is it supposed to be deployed? I see references to a folder C:/d/_Other/SlicerDMRI_D/lib/Slicer-4.7/Debug in AdditionalLauncherSettings.ini, but C:/d/_Other/SlicerDMRI_D/lib does not exist.

 

Any ideas?

 

Thanks,

csaba

 

 

 


_______________________________________________
slicer-devel mailing list
[hidden email]
http://massmail.spl.harvard.edu/mailman/listinfo/slicer-devel
To unsubscribe: send email to [hidden email] with unsubscribe as the subject
http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/FAQ